crowbar-core icon indicating copy to clipboard operation
crowbar-core copied to clipboard

Do not mix chef calls and proposal saves

Open dirkmueller opened this issue 9 years ago • 5 comments

Using chef calls while the propsal is still being modified can cause delays that would cause the transaction to be delayed so long that other workers get a busy exception. Shorten the lifetime of the critical section.

dirkmueller avatar Jan 29 '16 11:01 dirkmueller

I don't understand.

Does doing something like Proposal.where(barclamp: "crowbar", name: inst).first lock the database?

vuntz avatar Jan 29 '16 11:01 vuntz

So code looks correct; not sure if it will help us, but I'm fine trying.

vuntz avatar Jan 29 '16 11:01 vuntz

Using chef calls while the propsal is still being modified can cause delays that would cause the transaction to be delayed so long that other workers get a busy exception. Shorten the lifetime of the critical section.

I really don't understand how find_by should be related...

tboerger avatar Feb 02 '16 13:02 tboerger

@dirkmueller this has conflicts now. But I'm not sure we still need this...

vuntz avatar Feb 09 '16 13:02 vuntz

Do not merge for M11.

vuntz avatar Feb 10 '16 23:02 vuntz