crowbar-core
crowbar-core copied to clipboard
pacemaker: remove node on delete (SOC-11240)
On node delete, pacemaker needs to remove the node from the cluster prior to being deleted from crowbar. This change adds said feature.
Hmm. So I tried to test this (with crowbar-core/crowbar-ha packages that contain this pull request and https://github.com/crowbar/crowbar-ha/pull/376 as patches) and it doesn't yield what I'd expect to be the result. I deleted one controller...
root@crowbar:~ # knife node delete d52-54-77-77-01-02.vp5.cloud.suse.de d52-54-77-77-01-03.vp5.cloud.suse.de
Do you really want to delete d52-54-77-77-01-02.vp5.cloud.suse.de? (Y/N) y
Deleted node[d52-54-77-77-01-02.vp5.cloud.suse.de]
root@crowbar:
...and would have expected it to vanish from the stonith configuration in the cluster's proposal. It continues to be there though:
"stonith": {
"mode": "libvirt",
"sbd": {
"watchdog_module": "",
"nodes": {
"d52-54-77-77-01-01.vp5.cloud.suse.de": {
"devices": [
""
]
},
"d52-54-77-77-01-02.vp5.cloud.suse.de": { ### this should be gone if I understand the code correctly
"devices": [
""
]
},
"d52-54-77-77-01-03.vp5.cloud.suse.de": {
"devices": [
""
]
}
}
},
@jgrassler try to use "Forget" option in crowbar instead of direct deleting in chef.