[v2] namespaced resources don't have clean/tested examples
In the v2 compatible preview of provider-upjet-aws, we generate examples content for both cluster scoped and namespaced resources in the examples-generated directory.
However, these generated examples have not been cleaned and tested with uptest, so there are 0 namespaced examples in the examples directory. We even skip checking the namespaced resources for examples in the check-examples.py script - we should probably not do this long term.
I'm not entirely familiar with the process, but it's my understanding that this has historically been somewhat manual. That would be a large investment of time and energy to manually get these generated examples tested and committed.
Questions:
- Is there a better approach where we can take the tested examples of cluster scoped resources and transform them automatically into namespaced variants?
- Would the
xpkg batchcommand need to be updated in order to process namespaced examples too?
Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.
Transferred this issue from c/c, feels better homed over here in upjet repo 😇
Resources that depend on testhooks for a proper deletion order in E2E tests should also have the testhook api groups updated and namespace added to the hook script. For example: provider-upjet-azure namespaced hook example which targets cluster-scoped resource even though being used in namespaced tests. I'll update that when possible in providers Azure and AzureAD but imo it should be noted down here.