terrajet icon indicating copy to clipboard operation
terrajet copied to clipboard

Have more information when a make check-diff fails

Open remyleone opened this issue 2 years ago • 2 comments

What happened?

I've run the following command:

$ make check-diff 
15:26:39 [ .. ] verify dependencies have expected content
all modules verified
15:26:43 [ OK ] go modules dependencies verified
15:26:43 [ .. ] go generate darwin_amd64

Generated 39 resources!
15:26:55 [ OK ] go generate darwin_amd64
15:26:55 [ .. ] go mod tidy
15:26:55 [ OK ] go mod tidy
15:26:56 [ .. ] cleaning generated CRDs
15:26:56 [ OK ] cleaned generated CRDs
15:26:56 [ .. ] checking that branch is clean
15:26:56 [FAIL]
make: *** [check-diff] Error 1

This error seems to show that my branch is not clean. The problem is that I don't know by looking at the output of this command where the problematic files are. In case the return of git is not clean, could you show it in a diff format and/or a list of files that should be either moved or added?

How can we reproduce it?

remyleone avatar Feb 03 '22 14:02 remyleone

I believe this would be resolved when we update the build module to a recent version with this PR.

This requires a change in the jet-template and my open PR there already contains such an update.

turkenh avatar Feb 07 '22 09:02 turkenh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 00:08 stale[bot]