provider-template icon indicating copy to clipboard operation
provider-template copied to clipboard

chore: Bump up crossplane-runtime version to v1.18.0

Open cychiang opened this issue 1 year ago • 1 comments

Description of your changes

  • Bump up crossplane-runtime to v1.18.0
  • Fix linting issue by bumping up build submodules to latest one
  • Add support for logs that introduced in v1.17.0
  • Add support for metrics that introduced in v1.16.0
  • Update Delete function that required changes in v1.17.0
  • Bump up go version to 1.22

This PR is related to crossplane/crossplane#5924, and solve part of it.

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable to ensure this PR is ready for review.
  • [ ] ~~Added backport release-x.y labels to auto-backport this PR if necessary.~~

How has this code been tested

cychiang avatar Dec 28 '24 21:12 cychiang

very cool to see the classic provider template get some attention! thank you for taking the time to do that 🙇‍♂️

can you provide a few more details about how you tested that these changes work OK? is there a test/dummy provider build that you used the updated template for?

also, what was your general approach to get all these updates? did you follow the model of a particular up to date provider, look at the release notes, etc.?

My general approach for these updates are based on recent changes from crossplane-runtime. Also will try to use the same dependencies as same as crossplane-runtime.

After I finish the change, I will try to build and run in a local environment to test the template-provider is working or not.

cychiang avatar Jan 25 '25 23:01 cychiang

@jbw976 Hey, no problem! I will fix it before the end of next week.

cychiang avatar Apr 18 '25 11:04 cychiang

This mostly looks pretty complete to me @cychiang, thanks for continuing to drive it!

i've left a few comments for you - other than those, what else is left on your side before calling this complete? 👍

@jbw976 Hey! I think I have completed most of the things I can think about for bumping up the version. I'm going to ignore // +build generate issue, it seems not affect to generate process so I guess should be fine.

cychiang avatar Apr 21 '25 15:04 cychiang