docs icon indicating copy to clipboard operation
docs copied to clipboard

adds using secrets in a python function and cli --function-credentials

Open fabricebrito opened this issue 9 months ago • 8 comments

This PR adds documentation on how to use secrets in Python functions and extends the crossplane render --function-credentials=PATH cli

fabricebrito avatar Mar 28 '25 10:03 fabricebrito

Deploy Preview for crossplane ready!

Name Link
Latest commit 8097176394af8695278a1df8bad780062e9cf358
Latest deploy log https://app.netlify.com/projects/crossplane/deploys/689c426f161e950008d62218
Deploy Preview https://deploy-preview-902--crossplane.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 73 (🔴 down 4 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Mar 28 '25 10:03 netlify[bot]

@negz this is related to our chat in https://cloud-native.slack.com/archives/C01DCV0BS9H/p1742994912658039

fabricebrito avatar Mar 28 '25 10:03 fabricebrito

Nice work! Thank you.

negz avatar Mar 28 '25 18:03 negz

@fabricebrito Can you sign your git commit please - we need that before we can merge.

See https://github.com/crossplane/docs/pull/902/checks?check_run_id=39578510287 for context.

(git commit --amend -s should do it.)

negz avatar Mar 28 '25 19:03 negz

@negz the commit is now signed

fabricebrito avatar Mar 31 '25 08:03 fabricebrito

@fabricebrito Sadly it seems like the commits aren't signed - the DCO check is still failing.

negz avatar Apr 01 '25 13:04 negz

@fabricebrito something odd is going on in the history of your branch it seems like. I see multiple merge commits and some of my previous commits from #900 seem to be in your branch's history now too 🤔

Screenshot 2025-04-01 at 7 35 46 PM

Have you looked into using a git rebase workflow? Since I started doing that years ago, I have largely avoided any messy branch history - I've never looked back since adopting it 😂 https://simondosda.github.io/posts/2022-01-03-git-rebase-workflow.html

From the DCO check:

There are 4 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

All the commits in the branch must be signed off. I'm not quite sure what has happened in your branch, but it may be reasonable for you to start fresh and apply just your final changes (with a sign-off), instead of trying to continue cleaning things up.

jbw976 avatar Apr 01 '25 18:04 jbw976

I'm sorry for the mess. I'll start fresh.

fabricebrito avatar Apr 02 '25 14:04 fabricebrito

I've started fresh and submited #968

I'm closing this one

fabricebrito avatar Aug 13 '25 08:08 fabricebrito