Support revisionHistoryLimit in Composition

[jan-mrm]

What problem are you facing?

There is the known revisionHistoryLimit in many resources. Also in pkg.crossplane.io/Configuration and pkg.crossplane.io/Function.

It is not supported in apiextensions.crossplane.io/Composition, as far as I can see, or I'm missing it.

So the apiextensions.crossplane.io/CompositionRevisions are piling up on updates.

How could Crossplane help solve your problem?

Can revisionHistoryLimit be supported / added to apiextensions.crossplane.io/Composition or are there reasons that it should not be added?

[jbw976]

Do you think that what's described in https://github.com/crossplane/crossplane/issues/4837 would cover your requirements as well?

[jan-mrm]

Do you think that what's described in https://github.com/crossplane/crossplane/issues/4837 would cover your requirements as well?

Sure. revisionHistoryLimit was my first thought that came to my mind here, but there might be more to it. Not sure if a new Revision is directly taking over the older Revision so that it can safely be removed, e.g. when using revisionHistoryLimit: 0 or 1.

So yes, some garbage collection mechanism would solve my issue here as well, it does not have to be a revisionHistoryLimit.

Should I close this issue as a duplicate of the issue you linked or will you do so? Or do you want to keep it open?

[github-actions[bot]]

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.