crossplane-runtime icon indicating copy to clipboard operation
crossplane-runtime copied to clipboard

chore: added observedGeneration to the Ready and Sync condition

Open pintonunes opened this issue 11 months ago • 2 comments

Description of your changes

Today is pretty impossible to know when a managed resource is fully reconciled after an update. On creation we can check the Ready and Sync conditions to be True but on updates we never know if what we are seeing is the actual or the previous state.

Imagine we are updating an RDS cluster (long running async update) and by looking to the CR we cant tell if the update is done, in progress or if the controller is actually dead.

This PR adds the observedGeneration to the Ready and Sync conditions in the main reconcile loop since it was introduced with #633

Related with: https://github.com/crossplane/crossplane/issues/4695 https://github.com/crossplane/crossplane/issues/4655

I have:

Need help with this checklist? See the cheat sheet.

pintonunes avatar Nov 12 '24 15:11 pintonunes