crossplane-runtime icon indicating copy to clipboard operation
crossplane-runtime copied to clipboard

Managed Reconciler: Observe should be skipped if the resource is set to be deleted

Open soorena776 opened this issue 5 years ago • 1 comments

What happened?

Currently when reconciling a managed resource, it's Observe method is executed even if the resource is set to be deleted. The issue with this order is that if Observe for any reason fails, reconcile keeps throwing an error in this stage without ever reaching the Delete method. Since the resource is intended to be deleted, such observation errors should be ignored entirely.

What environment did it happen in?

Crossplane-runtime version: v0.3.0

soorena776 avatar Dec 31 '19 03:12 soorena776

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 13 '22 07:08 stale[bot]

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

github-actions[bot] avatar Sep 05 '24 01:09 github-actions[bot]