addon-oam-kubernetes-local

addon-oam-kubernetes-local copied to clipboard

The error this fixes is when the pod is trying to mount the webhook tls cert: ``` Events: Type Reason Age From Message ---- ------ ---- ---- ------- Normal Scheduled...

arturo-c

fix issue #49 change: wrap the error of util.PatchCondition into error being returned Signed-off-by: roy wang

captainroy-hy

error is not returned as expected

2

https://github.com/crossplane/addon-oam-kubernetes-local/blob/ed2006d2fe040237d332e8af94878421000fb055/pkg/controller/core/traits/manualscalertrait/manualscalertrait_controller.go#L141 If there's error returned from client.Get, it will not be returned because of `errors.Wrap` in until.PatchCondition. `fetchWorkload` may always return nil error. Then downstream check for `err != nil`...

captainroy-hy

[request] Make invisibility of local docker building/pushing, and remote docker pulling in Kubernetes cluster invisibilly

1

# Background [ko](https://github.com/google/ko/) is widely used during development and release of Knative components, which can make containers invisible infrastructure: No need to - run `docker build` - run `docker push`...

zzxwill

Repo `github.com/crossplane/oam-controllers` could NOT be found.

2

Like https://github.com/crossplane/addon-oam-kubernetes-local/blob/master/main.go#L30, repo `github.com/crossplane/oam-controllers` doesn't exists. I think it might need to be replaced with `https://github.com/crossplane/addon-oam-kubernetes-local`

zzxwill

Allow ManualScalarTrait to apply to workload directly and use duck typing

4

Our current implementation allows a `workloadDefinition` to directly reference anything with a GVK. This means one can also create a `workloadDefinition` that references a `deployment` or `statefulSet`. Therefore, `ManualScalarTrait` should...

ryanzhang-oss

Change cert-manager installation link

3

Per k8s cer-manager page(https://cert-manager.io/docs/installation/kubernetes/), the installation link for k8s >1.15 should be kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v0.15.0/cert-manager.yaml

szihai

This project should use the build submodule to be consistent with other projects in the crossplane organization. Release flows have been automated in the build submodule, and it would make...

bassam

Support Cron Trait

5

We used to discuss it in Rudr https://github.com/oam-dev/rudr/issues/40 I think this is really a common trait which can be `core` trait candidate

wonderflow