provider-sql icon indicating copy to clipboard operation
provider-sql copied to clipboard
verified publisher icon crossplane-contrib

chore: bump golangci version

Open fernandezcuesta opened this issue 10 months ago • 1 comments

Description of your changes

make lint command prompts deprecation warnings and fails to succeed with the current settings, mainly due to deprecated linters. This PR bumps golangci version and replaces some linters with the suggested alternatives, while sticking as much as possible to the original settings.

Fixes #

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested

make lint

fernandezcuesta avatar Feb 18 '25 21:02 fernandezcuesta

Can you also update it here: https://github.com/crossplane-contrib/provider-sql/blob/master/.github/workflows/ci.yml#L14

Done, thanks!

fernandezcuesta avatar Feb 21 '25 20:02 fernandezcuesta

Hi @Duologic I see this is failing due to some deprecated actions (https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/). WDYT about using this very same PR to bump the actions?

BTW just saw the dependabot PR which would have helped raising the flag here.

fernandezcuesta avatar Mar 05 '25 13:03 fernandezcuesta

@fernandezcuesta If you can add the publish-artifact bump to this PR, that would be great!

chlunde avatar Apr 23 '25 20:04 chlunde

@fernandezcuesta for some reason, we don't get any button here to approve workflows from first time contributor in this PR. Could you try and create a new PR, as it seems you already tried rebase and that didn't help.

chlunde avatar Apr 28 '25 13:04 chlunde