provider-sql icon indicating copy to clipboard operation
provider-sql copied to clipboard

Use bundled packages and update CI for publishing

Open chlunde opened this issue 3 years ago • 2 comments

Description of your changes

Based on work by @jastang in another repo.

Updates the build machinery to build bundled provider packages, as well as publish to crossplane-contrib OCI repos in both DockerHub and Upbound registries.

This is based on the branch for #115 which should be merged first.

xref crossplane/crossplane#3350

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested

./.cache/tools/linux_x86_64/up-v0.13.0 repository create provider-sql
chlunde/provider-sql created
VERSION=v0.6.0 make build.all
XPKG_REG_ORGS=xpkg.upbound.io/chlunde BRANCH_NAME=master VERSION=v0.6.0 make publish

chlunde avatar Nov 11 '22 17:11 chlunde

@jastang do you see what is missing here? Btw. do we need any secrets on the repo?

e2e also fails with: Error parsing reference: "/provider-sql-controller:v0.5.0-8.g17ac685" is not a valid repository/tag: invalid reference format

chlunde avatar Nov 11 '22 17:11 chlunde

Thanks @hasheddan - I didn't notice that! Publish tested OK:

./.cache/tools/linux_x86_64/up-v0.13.0 repository create provider-sql
chlunde/provider-sql created
VERSION=v0.6.0 make build.all
XPKG_REG_ORGS=xpkg.upbound.io/chlunde BRANCH_NAME=master VERSION=v0.6.0 make publish

To fix e2e, I had to remove this part from integration_test.sh, even though it is still in provider-kafka:

https://github.com/crossplane-contrib/provider-kafka/blob/main/cluster/local/integration_tests.sh#L90-L93

chlunde avatar Nov 20 '22 21:11 chlunde

@chlunde and @hasheddan Can you have another look at this PR?

Duologic avatar Aug 09 '23 17:08 Duologic

ugh, can't sign that -_-

Duologic avatar Aug 28 '23 18:08 Duologic

Merged through #153

Duologic avatar Sep 14 '23 14:09 Duologic