provider-helm
provider-helm copied to clipboard
crossplane-contrib
GKE Default Credentials and Temporary Access Tokens
Signed-off-by: Brad Wadsworth [email protected]
Description of your changes
Allow the default credential source to be used for authenticating to a GKE cluster.
A prerequisite for this change is https://github.com/crossplane/crossplane-runtime/pull/337 in order for InjectedIdentity to be used as an option for the CommonCredentialExtractor function.
Fixes #135
I have:
- [X ] Read and followed Crossplane's contribution process.
- [X ] Run
make reviewableto ensure this PR is ready for review.
How has this code been tested
Tested forked controller on a GKE cluster which was successful in applying the helm chart to a remote GKE cluster that had the appropriate IAM permissions for the provider-helm workload identity service account.
A prerequisite for this change is crossplane/crossplane-runtime#337 in order for InjectedIdentity to be used as an option for the CommonCredentialExtractor function.
@bradkwadsworth-mw thanks a lot for your contribution 🙌 I left a comment to the runtime PR which suggests only making a change here without any prerequisite there.
@turkenh Just wondering if you could take another look at this when you get a chance? Thanks.
@turkenh just wondering if I could get this looked at. This will mimic the functionality of this https://github.com/crossplane-contrib/provider-gcp/pull/461.
@bradkwadsworth-mw there is an interest in this feature, would you be able to continue working on this?
I tried to resolve conflicts but failed to push to the branch of this PR due to the lack of permissions.
Sure, I can try to take a look at it today.
On Mon, Jul 31, 2023 at 1:12 AM Hasan Turken @.***> wrote:
@bradkwadsworth-mw https://github.com/bradkwadsworth-mw there is an interest in this feature, would you be able to continue working on this?
I tried to resolve conflicts but failed to push to the branch of this PR due to the lack of permissions.
— Reply to this email directly, view it on GitHub https://github.com/crossplane-contrib/provider-helm/pull/136#issuecomment-1657727503, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATBY2ZNHTUOH6YDI4S4FAN3XS5EDPANCNFSM555HRL4Q . You are receiving this because you were mentioned.Message ID: @.***>
@bradkwadsworth-mw, could you also fix the DCO action so that we can merge this PR?