provider-gitlab icon indicating copy to clipboard operation
provider-gitlab copied to clipboard
verified publisher icon crossplane-contrib

feat: LdapGroupLinks

Open stempher opened this issue 7 months ago • 3 comments

Description of your changes

This PR adds LdapGroupLink functionality. This allows manage group memberships with LDAP.

https://docs.gitlab.com/user/group/access_and_permissions/#manage-group-memberships-with-ldap

Fixes #112

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  1. Unit tests have been created to test the controller and client functionality
  2. Tested in Kubernetes v1.30.2. I was able to create, update, delete and observe ldap sync's on various groups.

stempher avatar Jul 21 '25 14:07 stempher

Hey @stempher, your PR is missing the DCO / singoff - please see https://github.com/crossplane-contrib/provider-gitlab/pull/216/checks?check_run_id=46405055960

markussiebert avatar Oct 13 '25 05:10 markussiebert

Hi @stempher ,

thanks a lot for your PR! Due to the Crossplane v2 migration, we had to reorganize a lot of files. This is leading to conflicts in your branch now. We think it would be best to re-create your branch and your changes. Please don't forget to signoff as well as @markussiebert mentioned.

elaine-mattos avatar Oct 17 '25 07:10 elaine-mattos

@stempher could you please sign the DCO? else I would close this PR and just keep the issue

henrysachs avatar Dec 16 '25 10:12 henrysachs