provider-gitlab icon indicating copy to clipboard operation
provider-gitlab copied to clipboard

MemberRoleId not set when creating SamlGroupLink

Open jeremyj563 opened this issue 5 months ago • 0 comments

What happened?

When creating a managed resource of type SamlGroupLink the property MemberRoleId is not set. This field is necessary for creating a SAML Group Link to a Custom Member Role in GitLab.

How can we reproduce it?

We can see this property is missing in GenerateAddSamlGroupLinkOptions() here: https://github.com/crossplane-contrib/provider-gitlab/blob/31c53bce00c2e9b809716425c530bdc5e6fd4947/pkg/clients/groups/samlgrouplink.go#L53-L61

(also kindly note the minor typo in the comment on line 53)

What environment did it happen in?

Crossplane version: 1.16.0 Crossplane Provider GitLab version: 0.9.0

jeremyj563 avatar Aug 29 '24 20:08 jeremyj563