provider-gcp icon indicating copy to clipboard operation
provider-gcp copied to clipboard

Missing bigqueryConfig for pubsub subscriptions

Open POD666 opened this issue 2 years ago • 4 comments

What problem are you facing?

I want to provision a subscription with bigquery type but it seems to be missing.

How could Crossplane help solve your problem?

Add missing configs. I have manually configured a subscription this way:

$ gcloud pubsub subscriptions describe my-bigquery-subscription
ackDeadlineSeconds: 10
bigqueryConfig:
  state: ACTIVE
  table: ...
  useTopicSchema: true
  writeMetadata: true
enableMessageOrdering: true
expirationPolicy:
  ttl: 604800s
messageRetentionDuration: 86400s
name: ...
pushConfig: {}
retainAckedMessages: true
retryPolicy:
  maximumBackoff: 600s
  minimumBackoff: 10s
state: ACTIVE
topic: ...

POD666 avatar Oct 04 '22 14:10 POD666

I would prepare a PR and it's actually partially ready here but I have low exp with go and I'm stuck at updating google.golang.org/api from v0.52.0 to v0.97.0 (needed to include bigquery API struct).

I stuck at this:

$ make -j4                                                                                                                git:(bigquery-subscription-type) ✗  
18:07:04 [ .. ] verify go modules dependencies have expected content
all modules verified
18:07:07 [ OK ] go modules dependencies verified
18:07:08 [ .. ] go build linux_amd64
github.com/crossplane-contrib/provider-gcp/pkg/clients/cluster
github.com/crossplane-contrib/provider-gcp/pkg/clients/subscription
# github.com/crossplane-contrib/provider-gcp/pkg/clients/cluster
pkg/clients/cluster/cluster.go:1008:5: unknown field 'DesiredAutopilot' in struct literal of type container.ClusterUpdate
github.com/crossplane-contrib/provider-gcp/pkg/controller/pubsub
18:07:08 [FAIL]
make[3]: *** [go.build] Error 1
make[2]: *** [do.build.platform.linux_amd64] Error 2
make[1]: *** [build.all] Error 2
make: *** [build] Error 2

And indeed, DesiredAutopilot is gone from ClusterUpdate in the newer google.golang.org/api.

Any advice to proceed?

POD666 avatar Oct 05 '22 15:10 POD666

Hey @POD666, unfortunately, we already have two WIP PRs that are solving this issue.

  • https://github.com/crossplane-contrib/provider-gcp/pull/467
  • https://github.com/crossplane-contrib/provider-gcp/pull/470

I want to merge any of them ASAP to avoid this duplication of efforts and solve this problem.

Feggah avatar Oct 05 '22 22:10 Feggah

Oh, great. So the moment one of them is merged, I could rebase and proceed with bigqueryConfig.

POD666 avatar Oct 06 '22 11:10 POD666

Oh, great. So the moment one of them is merged, I could rebase and proceed with bigqueryConfig.

The #470 has been merged today. I think you can rebase and proceed now 🙂

Feggah avatar Oct 07 '22 00:10 Feggah