provider-gcp icon indicating copy to clipboard operation
provider-gcp copied to clipboard

Published 20 hours ago • verified publisher icon crossplane-contrib

Add Artifact registry Repository managed resource

Open mcbenjemaa opened this issue 2 years ago • 4 comments

Signed-off-by: Mohamed Chiheb [email protected]

Description of your changes

Added support for Artifact registry managed resource.

TODO: Add Tests

Fixes #404

I have:

  • [X] Read and followed Crossplane's contribution process.
  • [X] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

GCP

/cc @turkenh @muvaf

mcbenjemaa avatar Feb 13 '22 16:02 mcbenjemaa

Well, go 1.17 markers are there! +//go:build !ignore_autogenerated Updating the generator.

mcbenjemaa avatar Feb 13 '22 16:02 mcbenjemaa

Any chance this PR will be merged in the near future?

stoetti avatar Sep 01 '22 10:09 stoetti

I don't know if @mcbenjemaa is still working on this PR, there is a TODO to add tests to the resource before it can be merged.

I can review it by the end of the week, @stoetti. Just need some update from @mcbenjemaa

Feggah avatar Sep 14 '22 20:09 Feggah

@Feggah @mcbenjemaa

Any updates? What are the odds of this PR getting merged in the near future?

stoetti avatar Oct 17 '22 10:10 stoetti