provider-civo icon indicating copy to clipboard operation
provider-civo copied to clipboard

Published 20 hours ago • verified publisher icon crossplane-contrib

Added Object Store Support for Crossplane

Open satakshigarg opened this issue 2 years ago • 4 comments

Added the support for Object Store for Crossplane. [Internal/Controllers/objectstore.go is in progress, please ignore]

Signed-off-by: satakshigarg [email protected]

Description of your changes

Fixes #

I have:

  • [x] Read and followed Crossplane's contribution process.
  • [x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

satakshigarg avatar Sep 07 '22 12:09 satakshigarg

We need access key and secret access key stored in a secret. Similar to how we handle kubeconfig with clusters. I believe it is supposed to a field https://github.com/crossplane-contrib/provider-civo/blob/main/apis/civo/cluster/v1alpha1/types.go#L50

RealHarshThakur avatar Sep 07 '22 12:09 RealHarshThakur

https://github.com/crossplane-contrib/provider-civo/blob/main/apis/civo/cluster/v1alpha1/types.go#L50

@RealHarshThakur so shall I remove the access key from spec struct and just add a var to the secret struct to the spec that contains secret access key and access key ?

satakshigarg avatar Sep 07 '22 13:09 satakshigarg

We need access key in spec. Yes, add another field called ConnectionDetails similar to how we did in cluster spec

RealHarshThakur avatar Sep 07 '22 13:09 RealHarshThakur

Can we keep all directory & file names in a small case? (e.g /ObjectStore -> /objectstore)

LGTM

Sure, I'll update the same

satakshigarg avatar Sep 14 '22 08:09 satakshigarg