provider-aws icon indicating copy to clipboard operation
provider-aws copied to clipboard

Meta: Request Reviews from maintainers

Open MisterMX opened this issue 2 years ago • 2 comments

Description of the issue

Regular contributors (like me) don't have the ability to use Github's "Request Review" feature to ask a maintainer to look at a PR. They always have to tag a specific person in the request, like @haarchri or @muvaf. This slows down the review process because the addressed person might be unavailable at that time. It is also difficult for new contributors because they most likely do not know the maintainers and which to address.

How could this issue be solved

Add the ability to request a review from the provider-aws-maintainers team (or whatever you would like to call it) from the PR menu.

This might be interesting for other repos in crossplane-contrib as well although I am not sure if its a good idea to interfere with their development process from the outside.

MisterMX avatar Aug 22 '22 11:08 MisterMX

CODEOWNERS is also an option. For example we could be pinged any time someone makes a PR touching RDS, ElastiCache and SecurityGroups, and then maybe someone else could handle other controllers.

chlunde avatar Aug 23 '22 20:08 chlunde

@jbw976 fyi

haarchri avatar Aug 23 '22 20:08 haarchri

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

github-actions[bot] avatar Aug 22 '23 01:08 github-actions[bot]