crossoverJie
crossoverJie
@jaronoff97 Thank you for following up on this issue. > That results in what we agreed to be a confusing experience for users where a cluster admin needs to set...
Thanks for your reply, the following issues may require further discussion. > it's unclear to me why adding the name of the instrumentation in the application is more effort than...
@jaronoff97 Sorry for the delayed response. > What i'm thinking is a world where a cluster admin like yourself would define an instrumentation like so: Using a new CRD: `InstrumentationRules`...
> my cmd+enter pressed closed... oops! Hahaha, no worries.😂 > Would you be able to work on that design? I will draft a proposal for `InstrumentationRules` as soon as possible....
```yaml apiVersion: opentelemetry.io/v1alpha1 kind: InstrumentationRules metadata: name: instrumentation-prod # It will only select the Pods in this namespace. namespace: prod spec: # If the rule is not specified, the exporter/propagators/sampler...
```yaml apiVersion: opentelemetry.io/v1alpha1 kind: InstrumentationRules metadata: name: instrumentation-rule-for-namespace # It will only select the Pods in this namespace. namespace: prod spec: # If usedForNamespace is true, the rule will be...
cc @swiatekm @iblancasa https://github.com/open-telemetry/opentelemetry-operator/issues/2744#issuecomment-2232789129 https://github.com/open-telemetry/opentelemetry-operator/issues/2744#issuecomment-2244476064 Here is a new proposal regarding [select](https://github.com/open-telemetry/opentelemetry-operator/pull/2778), If you have time, please take a look.
> [@iamvishnuks](https://github.com/iamvishnuks) I'm planning on working on this sometime in the next couple of months, we've been having a lot of discussion around design considerations, breaking changes, etc. I'm hoping...
@jaronoff97 Maybe we don't need to modify the CR; we can implement it by referring to [this](https://github.com/open-telemetry/opentelemetry-operator/issues/4465#issuecomment-3510440253). ```yaml instrumentation.opentelemetry.io/container-names: xx instrumentation.opentelemetry.io/inject-java: xx ```
I agree with @gunli ; you can refer to the usage here. https://github.com/apache/pulsar-client-go/blob/06f4dd8bcff0abf6b80e4bee62c04c66c25d95b4/pulsar/producer_test.go#L153-L167