autobahn-js
autobahn-js copied to clipboard
crossbario
fix: put upper limit to dependency module versions
put upper limit to dependency module versions so that a major release don't break autobahn
Looks good. I guess it would make sense to do a new release after landing this change
couple of thoughts from my side - but @om26er : your advice ^ sounds good! I would love to transfer admin of this repo to the community. if you are interested (also others!), pls gimme a ping and we can discuss. also rgd ownership of the repo: this is also going to change - to a "WAMP Association"
in general, rgd dependencies, we should aim for 2 things:
- have no version restrictions for dependencies of this library, so that the library can be used in apps that nail their deps. if we restrict a dependency of autobahn already within autobahn, then an app that also (directly) uses that dependency might disagree (I've run into such issues quite some times .. it is annoying and tricky to work around)
- do have version restrictions for dependencies of this library, so that we don't get affected by changes of these.
now, obviously, you can't have both 1 and 2. means, this is a conflicting goal and tradeoffs have to be made.
because of above, I would argue for only adding the absolute minimum version restrictions to our dependencies in the library itself plus a comment that explain/links to the reason for the (upper bound) restriction so that it might be removed later.
@vnktswrl having no upper limits in dependencies is desired (see above) and not an error. if you run into a specific newer dependency that doesn't work, we can limit the dependency - but only for that single dependency, not all deps.
fwiw, in my eyes the word "major" in "major release" of a dependency is arbitrary ... semantic versioning is an illusion ..