autobahn-cpp icon indicating copy to clipboard operation
autobahn-cpp copied to clipboard

Handshake should be synchronous

Open davidchappelle opened this issue 9 years ago • 1 comments

The capabilities handshake that is performed at the start of a session should be a synchronous operation or at least return a future that can be waited upon so that you can be prevented from trying to join a session before the handshake has completed. We must ensure that the wamp router that we are connecting to can even support our capabilities before trying to establish a session. Based on the current coding style the future returned by a call to start a session should look as follows:

boost::promise<bool> m_handshake;

inline
boost::future<bool> start();

I will write-up a patch for review.

davidchappelle avatar Apr 10 '15 17:04 davidchappelle

This is fixed in my fork: Implemented in my fork: https://github.com/davidchappelle/AutobahnCpp

davidchappelle avatar Jul 02 '15 14:07 davidchappelle