cross icon indicating copy to clipboard operation
cross copied to clipboard

Link to libgcc for `armv5te-unknown-linux-musleabi` target.

Open Alexhuszagh opened this issue 2 years ago • 2 comments

Fixes missing sync builtins required for libraries such as OpenSSL, specifically, the __sync_X_and_fetch builtins.

Closes #367. Improves documentation related to #906.

Alexhuszagh avatar Jul 30 '22 16:07 Alexhuszagh

I'm not sure this is something we should do since it's an upstream issue and will eventually be fixed hopefully.

Emilgardis avatar Jul 30 '22 17:07 Emilgardis

I'm not sure this is something we should do since it's an upstream issue and will eventually be fixed hopefully.

It is, it's already been patched (I submitted https://github.com/rust-lang/compiler-builtins/pull/484 which was merged), but we need to wait for a stable release similar to what we do in aarch64-linux-musl-gcc.sh Similarly, we can remove -libgcc shortly when https://github.com/rust-lang/compiler-builtins/pull/483 makes it to stable.

Alexhuszagh avatar Jul 30 '22 17:07 Alexhuszagh

bors r=Emilgardis

Alexhuszagh avatar Aug 10 '22 16:08 Alexhuszagh

Build failed:

bors[bot] avatar Aug 10 '22 17:08 bors[bot]

bors try --target mips64-unknown-linux-muslabi64

Alexhuszagh avatar Aug 10 '22 17:08 Alexhuszagh

try

Build succeeded:

bors[bot] avatar Aug 10 '22 18:08 bors[bot]

bors r=Emilgardis

Alexhuszagh avatar Aug 10 '22 18:08 Alexhuszagh

Build succeeded:

bors[bot] avatar Aug 10 '22 18:08 bors[bot]