cross icon indicating copy to clipboard operation
cross copied to clipboard

remove actions-rs

Open Emilgardis opened this issue 1 year ago • 10 comments

This essentially removes all actions-rs actions and replaces it with what is needed.

Reason for this is due to actions-rs being seemingly unmaintained

Emilgardis avatar Jul 15 '22 23:07 Emilgardis

this follows the general consensus as discussed in https://github.com/actions-rs/toolchain/issues/216

it also adds a matcher, which would otherwise be gone

Emilgardis avatar Jul 15 '22 23:07 Emilgardis

bors r=@Alexhuszagh

Emilgardis avatar Aug 10 '22 16:08 Emilgardis

Build failed:

bors[bot] avatar Aug 10 '22 16:08 bors[bot]

bors try --target x86_64-unknown-linux-gnu

will squash (and rebase) on success)

Emilgardis avatar Aug 10 '22 16:08 Emilgardis

try

Build succeeded:

bors[bot] avatar Aug 10 '22 17:08 bors[bot]

bors try --target x86_64-unknown-linux-gnu

going to give it a careful re-review, but looks good so far.

Alexhuszagh avatar Aug 12 '22 22:08 Alexhuszagh

try

Build succeeded:

bors[bot] avatar Aug 12 '22 22:08 bors[bot]

Relatedly, but not necessarily relevant for this particular PR, I have been thinking about creating a cross-rs/install action which would install the cross binary from our GitHub releases rather than having to build it from source in CI every time.

reitermarkus avatar Aug 12 '22 23:08 reitermarkus

Relatedly, but not necessarily relevant for this particular PR, I have been thinking about creating a cross-rs/install action which would install the cross binary from our GitHub releases rather than having to build it from source in CI every time.

That sounds good, it is possible to use https://github.com/taiki-e/install-action for now, but would be neat to have, and easy to support 👍🏼

Emilgardis avatar Aug 12 '22 23:08 Emilgardis

Neat, didn't know about https://github.com/taiki-e/install-action.

reitermarkus avatar Aug 12 '22 23:08 reitermarkus

Still looks good after #1033, am I free to merge this @Emilgardis?

Alexhuszagh avatar Oct 02 '22 12:10 Alexhuszagh

Yep @Alexhuszagh

Emilgardis avatar Oct 02 '22 13:10 Emilgardis

bors r=Alexhuszagh,reitermarkus

Alexhuszagh avatar Oct 02 '22 13:10 Alexhuszagh

Build failed:

bors[bot] avatar Oct 02 '22 13:10 bors[bot]

bors try --target *windows-msvc

Emilgardis avatar Oct 02 '22 13:10 Emilgardis

bors try --target *windows-msvc

Emilgardis avatar Oct 02 '22 14:10 Emilgardis

bors try --target *windows-msvc

Emilgardis avatar Oct 02 '22 14:10 Emilgardis

try

Already running a review

bors[bot] avatar Oct 02 '22 14:10 bors[bot]

bors try- bors try --target *windows-msvc

Emilgardis avatar Oct 02 '22 14:10 Emilgardis

bors try- bors try --target *windows-msvc

Emilgardis avatar Oct 02 '22 14:10 Emilgardis

try

Build failed:

bors[bot] avatar Oct 02 '22 15:10 bors[bot]

bors try --target *windows-msvc

Emilgardis avatar Oct 02 '22 15:10 Emilgardis

try

Build succeeded:

bors[bot] avatar Oct 02 '22 15:10 bors[bot]

it works!

image

Emilgardis avatar Oct 02 '22 15:10 Emilgardis

Build succeeded:

bors[bot] avatar Oct 02 '22 16:10 bors[bot]