cross icon indicating copy to clipboard operation
cross copied to clipboard

enable tests on windows and macos ci platform

Open Emilgardis opened this issue 2 years ago • 8 comments

enable ci/tests.sh to run on ci for windows and macos

Emilgardis avatar Nov 19 '21 19:11 Emilgardis

This has been partially solved with #609, we still do not test cross with these images.

We should test every image we produce with Linux, Mac and Windows GHA runners.

Emilgardis avatar Mar 17 '22 15:03 Emilgardis

we still do not test cross with these images.

We don't have images for these targets, so what is there to test?

reitermarkus avatar Mar 17 '22 15:03 reitermarkus

We do, don't we? https://github.com/cross-rs/cross/pkgs/container/x86_64-pc-windows-gnu

As for testing, I mean tests to catch stuff like #461

Emilgardis avatar Mar 17 '22 15:03 Emilgardis

I'm struggling with coming up with a satisfactory way to solve this.

Alt 1.

Artifact all images in docker-images and in a new action image-tests step that needs docker-images get all image artifacts, try a subset of those artifacts on windows, linux and macos on some example workspaces, and then on success run publish step which publishes the artifacted images etc.

Alt 2.

run scheduled task that tests current main images with windows/mac/linux on some example workspaces.

Emilgardis avatar Mar 20 '22 12:03 Emilgardis

We could test for a single platform on macOS and Windows, build a single image fetched from cache (choose one unlikely to change for the best performance) and just install the latest cross and run from our cache?

We don't provide images for *-msvc or *-apple-*, so I think just testing CI works for an image we support on Windows and macOS is a good idea?

Alexhuszagh avatar Jun 16 '22 18:06 Alexhuszagh

That should work, there is one thing to be careful of then however, changes that break mac/windows won't be catched if the conditions needed to break are not in the cached image.

Emilgardis avatar Jun 16 '22 18:06 Emilgardis

That should work, there is one thing to be careful of then however, changes that break mac/windows won't be catched if the conditions needed to break are not in the cached image.

At least we'll catch them relatively early with the weekly update, so we can triage pretty quickly.

Alexhuszagh avatar Jun 16 '22 19:06 Alexhuszagh

this will have to be implemented on self-hosted runners, see https://github.com/actions/virtual-environments/issues/252 and https://github.com/actions/virtual-environments/issues/2150

Emilgardis avatar Jun 24 '22 20:06 Emilgardis