PlexKodiConnect
PlexKodiConnect copied to clipboard
croneter
Change skip intro and credit buttons
Hi,
the buttons for skip intro and skip credits look a little old fashioned IMO. Could you change it to a more modern looking button like plex itself has? And maybe an option to change the location if it's not too much to ask?
Sorry, this is front-end and thus COMPLETELY not my area 😢. Pull requests are always welcome though.
Okay, I can do that. Do you have an easy way to test changes? Or do I just start a tv show episode over and over again in kodi every time I make a change to the xml file? xD
Great! No sorry, you'll have to fire up Kodi again and again to test your changes.
@Shawn9347 script-plex-skip_marker.txt That's how I changed it for me. Very minimal and fades to 20% opacity after 5 seconds so it doesn't disturb as much if I decide to watch the intro/credits. Maybe you can use this hack job as an inspiration.
Yea I found the file as well. Best would be that the button goes away after a few seconds and is visible whenever you open the player controls just like in plex.
I wouldn't want the button to disappear completely. Always good to know that skipping is possible without having to open player controls. Did try that before. Had the button go away after 5 seconds. Didn't like it as much as how I do it is now. Sometimes I wasn't sure I could skip because I didn't pay attention in the beginning. Maybe you try my solution and see if you like it :)
border doesn't work in this case. I don't know why yet. I would like to add rounded corners.
Okay I have no clue how to fix this. This is totally not my specialty either. But, @croneter at least remove the shadow around the button. The width of the shadow is litteraly the entire screen so that's really annoying obviously.
It's this part.
<control type="group"> <height>64</height> <control type="image"> <width>100%</width> <height>64</height> <texture colordiffuse="44000000">skipintro-background.png</texture> </control>
@Shawn9347 script-plex-skip_marker.txt That's how I changed it for me. Very minimal and fades to 20% opacity after 5 seconds so it doesn't disturb as much if I decide to watch the intro/credits. Maybe you can use this hack job as an inspiration.
This version has issues as well. There's a blue line across the text and no idea why.
@Shawn9347 script-plex-skip_marker.txt That's how I changed it for me. Very minimal and fades to 20% opacity after 5 seconds so it doesn't disturb as much if I decide to watch the intro/credits. Maybe you can use this hack job as an inspiration.
How did you get that border effect? I want to make it less but none of the values in the code change the border.
May I ask you where do I have to put script-plex-skip_marker.txt in order to "deploy" it? :)
@thorindwarf just replace this file with it: \addons\plugin.video.plexkodiconnect\resources\skins\default\1080i\script-plex-skip_marker.xml notice that it should have .xml as the extension. I just uploaded it as .txt because github doesn't like xml for some reason
Is this file still used? I tried modifying the file but nothing changes. When I completely remove the script-plex-skip_marker.xml file the skip intro button still works.
Yes @Shawn9347 that file is being used, see e.g. here: https://github.com/croneter/PlexKodiConnect/blob/4dcb12a1e95dd5d555cd8386bdba9edb8c95c86a/resources/lib/windows/skip_marker.py#L12