Jason A. Crome
Jason A. Crome
Resolved by #1681. Closing.
Merged, thanks @renderorange!
@sdondley One more ping before I close this out. Can you provide some guidance on how you planned to use this so we can discuss this?
@sdondley thanks for getting back with me. I'm going to close this for now. If you remember what it was and want to discuss it, please feel free to add...
Is there a reason a number of tests were commented out in `t/app.t`? The tests that changed to account for your patch make sense to me, but it seems like...
Approved :+1: @xsawyerx I'm considering your approval to still be valid as the core code remains unchanged since when you approved it.
Make sure to document usage from a template: ``` [% request.uri_for_route( 'my_route_name', { 'foo' => 'bar' }, { 'id' => 4 } ) %] ```
👏 This looks great. Thanks for walking me through this. An emphatic 👍 from me.
Excellent! I'll work on getting a release put together over the next couple of days. Thanks everyone!