Sanne Raymaekers
Sanne Raymaekers
I enabled it for IB as I liked the static analysis on PRs; it does find issues sometimes. Time to migrate I guess!
I took a stab at it but without a lot of knowledge of all the edge cases of the rather complex router code I have no idea if it's a...
Ah, that seems weird to me, returning the `NotFoundHandler` when there's a better candidate (path match but not method).
Ah I get that, but I'm not sure if it should take priority over the exact path match as in the reproducer. Note that with this patch calling the group...
Right, but with `Use` the Router definitely has to be involved no? Like the middleware should only apply with a request to a valid endpoint? So we can't just comment...
Yea and I think that behaviour remains intact for https://github.com/labstack/echo/commit/584291d81be55157100dc04754ef938c45565ec3. The commit message isn't entirely correct however, really it should be something like: > only return the notfoundhandler for `anykind`...
Yes, but ideally we could offload this to ostree itself. https://github.com/ostreedev/ostree/pull/1847 existed, but is closed now. I want to avoid having to retry the entire stage/pull, only fetching the individual...
I migrated ib, https://github.com/osbuild/image-builder/pull/485
So for vmware ovas I added an ovf stage as well: https://github.com/osbuild/osbuild/blob/722d02310459dbd7de0a783f9bb8c34fef146f1f/stages/org.osbuild.ovf#L36 I wonder if it would be possible to refactor that stage to also generate non-vmware ovf descriptors, and...
Still worth an investigation. I had multiple timeouts today and none of them showed up on the dashboard: 