rpg-cards icon indicating copy to clipboard operation
rpg-cards copied to clipboard

Problem when generating cards for printing - missing css/class-icons.css

Open Rushino opened this issue 11 months ago • 2 comments

Hello,

The generator seem to have a missing css named css/class-icons.css. When i click generate, i see the cards for a second then "object object" appear on the screen. If you check in the console, it seem there a missing CSS not on the server.

Rushino avatar Mar 19 '24 02:03 Rushino

Hey! I'm having the same issue! have you tried to execute the project locally?

raitocan avatar Mar 22 '24 05:03 raitocan

Yup it seem to work once you build it locally.

Thank you!

Le ven. 22 mars 2024, 01 h 09, João Marcos A. M. Ramos < @.***> a écrit :

Hey! I'm having the same issue! have you tried to execute the project locally?

— Reply to this email directly, view it on GitHub https://github.com/crobi/rpg-cards/issues/187#issuecomment-2014363534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATTHTX3LZP5Z2NZRC56UYDYZO4JVAVCNFSM6AAAAABE4WALL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJUGM3DGNJTGQ . You are receiving this because you authored the thread.Message ID: @.***>

Rushino avatar Mar 22 '24 11:03 Rushino

https://github.com/crobi/rpg-cards/blob/e449f5559d9940df795bd21fc52ec6defbd293e3/generator/output.html#L26 should be removed

maybe https://github.com/crobi/rpg-cards/commit/bef3e2740d52d751c7d7b7081c56241a1ed5965d got reverted at some point? Picking that commit may fix things

syntroniks avatar Apr 22 '24 16:04 syntroniks

Disabling react dev tools actually fixed this for me.

syntroniks avatar Apr 22 '24 17:04 syntroniks

I removed the unused css link.

I fixed the [Object object] text in output.html too. Now a "Close" button appairs if the render fails or if you reload the page.

Thanks for your feedback!

mephitrpg avatar Apr 23 '24 00:04 mephitrpg