rpg-cards icon indicating copy to clipboard operation
rpg-cards copied to clipboard

Generator overlapping cards

Open TheValko opened this issue 7 years ago • 7 comments

When i generate a list of cards the generator starts to overlap cards and display them incorrectly. It displays the same way in the print screen as well

TheValko avatar Oct 29 '17 19:10 TheValko

This happens when you try to fit too many cards on one page. What are your settings (card size, page size, number of cards per page)?

crobi avatar Oct 30 '17 21:10 crobi

I am using the standard default setting of A4 pages, 2.5 x 3.5 cards and 3x3 per page. about half of my list shows up perfectly then it messes up.

TheValko avatar Oct 31 '17 23:10 TheValko

I'm seeing the same issue.

  • US Letter
  • 2.5 x 3.5 card size
  • 3x3 per page
  • 27 cards total (so exactly 3 full pages)

ja-liviero avatar Nov 11 '17 15:11 ja-liviero

Managed to fix it for myself. I found an un-closed italics tag (<i><i> instead of <i></i>).

A bit out of scope here, but what about adding _words_ and **words** as formatting keys for italics and bold respectively, to avoid this hiccup? That method is already commonly used in many places, including this here.

ja-liviero avatar Nov 12 '17 02:11 ja-liviero

Yep, that's what was wrong with mine as well. Nice catch, thanks a lot!

TheValko avatar Nov 12 '17 22:11 TheValko

Good to hear you found the issue. If you're up to it, feel free to propose a new feature (either validating html tags or implementing _word_, **word**, *word*, and ~word~ formatting) in a new issue (or even better, implement it and post a PR).

crobi avatar Nov 13 '17 12:11 crobi

I'd be happy to submit a PR, but it might be a little while before I get to it. Thanks!

ja-liviero avatar Nov 19 '17 03:11 ja-liviero