shortkeys icon indicating copy to clipboard operation
shortkeys copied to clipboard

Deleting a shortcut also deletes the row with the same shortcut key

Open Zankio opened this issue 1 year ago • 1 comments

When deleting the first shortcut, the second one is also deleted. Eample

  1. Shortcut a for site A
  2. Shortcut a for site B

Zankio avatar Sep 21 '24 15:09 Zankio

Relevant code:

https://github.com/crittermike/shortkeys/blob/83750b29091aed50f04af05f384a1bb3f61ca64a/app/options/options.vue#L253-L256

Should probably be changed to regular reference equality, if that works:

-                onConfirm: () => this.keys = this.keys.filter(curKey => key.key !== curKey.key)
+                onConfirm: () => this.keys = this.keys.filter(curKey => key !== curKey)

Susko3 avatar Nov 15 '24 21:11 Susko3