JVips icon indicating copy to clipboard operation
JVips copied to clipboard

Confusing naming\function Image#imageGetFormat

Open bademux opened this issue 4 years ago • 1 comments

I think there is can be problem with VipsBandFormat vs VipsImageFormat especially for Image#imageGetFormat function. I'm also curious about naming convention: it isn't clean for me why iit is named like imageGetFormat, and not getImageFormat (getBandFormat ?)

https://github.com/criteo/JVips/blob/885974dd5c6f10f7b1986aa58993aad64754736f/src/main/java/com/criteo/vips/Image.java#L66

bademux avatar Jul 25 '20 16:07 bademux

Hello, I took the original libvips function name, I removed the vips prefix and the underscores. The function names are in came case. This is why it is imageGetFormat(). We could maybe remove the image prefix because this is an VipsImage method.

dbouron avatar Jul 26 '20 15:07 dbouron