Cris Ward

Results 66 comments of Cris Ward

This plugin works by cloning the repo into a temp directory, then pushing it to dokku. So shouldn't be a big deal to update this to allow a hash, however...

Thanks for the suggestion and having a go, and more importantly testing. I'll leave this open, but I can't promise I'll get chance to look at it any time soon.

Have you tried adding `.git` to the end of the url. You should be using the git url, not the web address eg. `dokku clone seekpath3 https://github.com/materialscloud-org/tools-seekpath.git v20.11.0`

>Looks good though, wondering why this hasn't been reviewed / commented on Usual reason, not something I need so didn't get round to testing / merging. To manually test this...

What options would you have under phase?

Just to clarify, it never 'recreates' a plugin if it already exists. So if you have postgres setup and linked, it will not add it the second time. But if...

The problem with the middleware solution is it's completely invisible to the developer working on the route. I think middleware makes more sense when more general, perhaps adding content-json headers...

Ok. Any preference on the above. On reflection I think I prefer 2 (standard middleware handlers), especially as you could use existing middleware like this. The definition is more verbose,...

As @samueleaton pointed out, the response is write-only io. It can't be read or modified because it's probably already been sent to the client. The only way to achieve this...

@nullbio I was also getting this error with Esbuild and it seemed to happen when I linked other libraries that also included svelte. Esbuild wasn't de-duping the svelte import, so...