Sim800l icon indicating copy to clipboard operation
Sim800l copied to clipboard

Added softReset and functions to test and set network time

Open rharrison opened this issue 5 years ago • 3 comments

Sorry I ran pretty on the code and set TX & RX to pins 3 & 2 respectively.

rharrison avatar Jan 26 '19 17:01 rharrison

Hi @rharrison, first of all thanks for your contribution, but why do you change the pins for Rx & Tx? The pin 2 optionly was thinking to be the reset pin. BR.

cristiansteib avatar Jan 26 '19 18:01 cristiansteib

No real reason other than lots of the examples were out there with pins 2&3 and rather than changing the wires I changed the code. I forgot before I pushed the change up so I put it in the notes it should probably be put back to 10 and 11 or it will break for other people. Sorry.

I have a couple more changes to submit to make sure the message is in the right format. If you are interested in these changes I will tidy my code up a bit and I will submit a few more examples to cover the new changes.

Thanks for your work.

Robert

Sent from my iPad

On 26 Jan 2019, at 18:39, Cristian Steib <[email protected]mailto:[email protected]> wrote:

Hi @rharrisonhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frharrison&data=02%7C01%7Crharrison%40hgf.com%7C338905fb04f94b055a2908d683bd8984%7Cbd4a58fa2d194bfa921bf6f222043055%7C0%7C0%7C636841247422553935&sdata=qTesJkVqRXNOQDL8cWvXV91yHWuVWq%2FRNT6mhFyKcLg%3D&reserved=0, first of all thanks for your contribution, but why do you change the pins for Rx & Tx? The pin 2 optionly was thinking to be the reset pin. BR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcristiansteib%2FSim800l%2Fpull%2F29%23issuecomment-457854705&data=02%7C01%7Crharrison%40hgf.com%7C338905fb04f94b055a2908d683bd8984%7Cbd4a58fa2d194bfa921bf6f222043055%7C0%7C0%7C636841247422563940&sdata=8EMACpqZcxrH3LTz8EVVUMads5EJvGHcMAYCgP0E%2BVM%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAN2rgdkAd983GBAD6mxhOuxv57mG3jDks5vHKCrgaJpZM4aURAa&data=02%7C01%7Crharrison%40hgf.com%7C338905fb04f94b055a2908d683bd8984%7Cbd4a58fa2d194bfa921bf6f222043055%7C0%7C0%7C636841247422563940&sdata=VyqfQ4Po5L%2FAXCPOO3bOLAG9GGy%2Bb9BnENxXXkvrPEg%3D&reserved=0.


This email has been scanned for spam & viruses. If you believe this email should have been stopped by our filters, click herehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fportal.mailanyone.net%2Findex.html%23%2Fouter%2Freportspam%3Ftoken%3DdXNlcj1yaGFycmlzb25AaGdmLmNvbTt0cz0xNTQ4NTI3OTM4O3V1aWQ9NUM0Q0E5MzM0QzFCNDZGRUQyOEU3NkQyRjRFMkM0MEE7dG9rZW49YThkYzZiM2RkZDExNjQ4ZTY4NjFmYWY5MjJkMjY3NGY1ZmNlMWYwYTs%253D&data=02%7C01%7Crharrison%40hgf.com%7C338905fb04f94b055a2908d683bd8984%7Cbd4a58fa2d194bfa921bf6f222043055%7C0%7C0%7C636841247422573949&sdata=USQ%2F45lptCYyVfHtvFKt8RQk4j8y4ygmhxhNR6Z%2BGOA%3D&reserved=0 to report it.

rharrison avatar Jan 26 '19 22:01 rharrison

Please change the pinout. Probably is better add parameters to the instanciation. Your changes are welcome, do a pull request will your changes :)

cristiansteib avatar Feb 03 '19 04:02 cristiansteib