SwiftySuncalc
SwiftySuncalc copied to clipboard
Moon time and position bugs
Thanks for this nice little library! I have been testing it with the real world observations and found issues
- When Moon sets on next day after rise day, but the reported Date is NOT incremented, so code reports moon sets before it rises on same day. Possible fixes here:
- just before the return result in getMoonTimes, check for set < rise, if so, increment the day component.
- since moon does not set on that day, leave set value at nil #2 is probably preferable and in keeping with original BASIC code
1a) Moon rise time is within a minute of Nat. Obs., but today, your code reports set of 00:00 and N.O. reports 00:40
- Moon position appears biased to the east (CCW on the ecliptic). Poor weather conditions locally gives me only a single observation day where offset appeared to be 70° ! Will test more rigorously and reported back