Oleg Kovalov

Name: `???` Before: ```go res := strings.Split(text, "-")[0] ``` After: ```go i := strings.Index(text, "-") res := text[:i] ``` There might be other patterns for other `strings` package functions.

lint: utf8 names

1

Name: `utf8Names` Before: ```go ooɟ := "boom" // oh no :\ ``` After: ```go foo := "boom" ```

lint: shorter if & return bool

3

Name: `???` Before: ```go if foo, ok := bar.(*baz); ok { return fun() } return false ``` After: ```go foo, ok := bar.(*baz) return ok && fun() ``` From: https://github.com/go-critic/go-critic/pull/396#discussion_r201128256

Currently docs (`overview.md` file to be exact) isn't updated automatically in this repo https://github.com/go-critic/go-critic.github.io but it can be 😄 To generate new docs you need to run `make docs` from...

Makefile step should create simple checker with a given name and directory with the empty test files.

lint: consider to add helper marker for functions in test files

1

before: ```go // code_test.go func testHelper(t *testing.T, params ...interface{}) interface{} { ... } ``` after: ```go // code_test.go func testHelper(t *testing.T, params ...interface{}) interface{} { t.Helper() ... } ``` This...

lint: suggest to rename camelCase files

7

Name: `???` Before: ```bash /usr/home/go/src/pkg/testSuite.go ``` After: ```bash /usr/home/go/src/pkg/test_suite.go ```

lint: warn on an unchecked error

6

Name: `uncheckedErr` Before: ```go a, err := foo() if err != nil { ... } b, err := bar() // err wasn't checked baz() ``` After: ```go a, err :=...

lint: dummy regex

1

Name: `???` Before: ```go var re = regexp.MustCompile("^TODO") ``` After: ```go var f = func(s string) bool { strings.HasPrefix(s, "TODO") } ``` Dummy patterns: `^foo`, `foo$`, `.*foo.*`

lint: suggest to make channel directed

1

Name: `???` Before: ```go func f() chan int { // ch is used only for write in foo, so outside there is only read from it ch := make(chan int,...