Oleg Kovalov
Oleg Kovalov
Probably this can be done as a yet another makefile step :D 1. Download/checkout list of repos. 2. Run `go-critic` over them. I'm sceptical about adding such test on CI....
Meh, I'm scared that this will make CI slower. Even if it's parallel. My assumptions are based on: fetch repos (few minutes), build `critic`, run it. And due to CI...
Growing testdata isn't much better imo. Why do we need to throw additional KBs of code for tests? + updates + fetch time (see CI). This will be even more...
Good thing to start https://github.com/mvdan/corpus/
Well...we will update it regularly and automatically 😉
@mastertinner thanks for refreshing this issue. Will be pushed in next days :)
Looks like it's time for it. BTW we've integrated with https://github.com/golangci/golangci-lint/pull/273 so it may solve this task and add few more feature. Sorry for holding this issue for a long...
Bump, I'm adding goreleaser 🤞
Looks like it replaces with a whole string instead of a body: https://github.com/go-critic/go-critic/blob/master/checkers/rules/rules.go#L120 & https://github.com/go-critic/go-critic/blob/master/checkers/rules/rules.go#L122
I don't see any problems with adding YAML support and it's not so hard. Have created #556