Chris Truter
Chris Truter
Definitely see how it could be stressful - the first time through you're trying to understand what all those labels mean and associate the colours together. Perhaps it could be...
@boxed apologies for letting this rot. If there's still steam here I have some time to try GIFinating again, just wanted to gauge interest first.
Backend changes LGTM
I've broken the force migration test, so clearly I've missed something important - hopefully not fundamental.
> I'm a bit on the fence about nesting the `with-scope-locked`. it's too easy and temping to just use it wherever we want. I think a better mechanic is to...
Another idea would just be to add a function that checks lock status via the `liquibase` variable, and could called it `locked-liquibase` if we want a clearer indication in the...
Current dependencies on/for this PR: * `master` * **PR #38810** 👈 This [stack of pull requests](https://stacking.dev/?utm_source=stack-comment) is managed by [Graphite](https://app.graphite.dev/github/pr/metabase/metabase/38810?utm_source=stack-comment).
Took a quick look into why the `be-tests-java-X-oss` suites are failing, and here's what it looks like: - An assertion on the shape of a map in `metabase.api.collection-test/collection-items-return-cards-test` fails due...
Just FYI, I see CI is failing. It appears to be an issue that's on master. I've posted about it on #engineering-ci.
Passing in the options is interesting, but not sure the best way to pass named arguments in - positional would be awkward and hard to extend. I'll add an error...