Cris Busquets

Results 13 comments of Cris Busquets

@simison @pkuliga > It's very important the name of the block is clear, so to separate it clearly from regular site's own login block, as well as paywall and other...

> Oh that's weird, Gutenberg has been moving to sentence case in UIs and so has WordPress.com everywhere in UIs, but looks like not in Blocks. > > Agree on...

For the description: Show links for subscribers to login, logout, or manage their subscription. For the icon, we can reuse this: `block-comment-author-gravatar`. It implies "account avatar". However, I'd rather design...

## Flow @pkuliga here's the flow. I've added how it would look like in Gutenberg and in a post. Figma file: yJiLZt1ozJqMltHHQxR4Gc-fi-4392_12514 ![subscribe-block-flow](https://github.com/Automattic/jetpack/assets/25607244/38eff4da-7c87-4cf1-b828-b5a7339c165e) ## Modals update To fit the subscribe...

After discussing it with @pkuliga, we've updated the padding-top for the header. Here's the updated Figma file with all the specs: - Subscribe modal: yJiLZt1ozJqMltHHQxR4Gc-fi-4416_3255 - Tiers modal: yJiLZt1ozJqMltHHQxR4Gc-fi-4416_3412 -...

From what I see on the video, it works for me. The tooltip has enough contrast and it's easy to read. Related to the accessibility concerns, does it have Aria...

Hi @pkuliga ! I tested it and it works as expected. But based on what I shared on the i3 post, can we release a version with this structure?: Instead...

> @crisbusquets adding a main toggle introduces too much complexity. Let's do it when we have more toggles. But I wasn't referring to the main toggle for Newsletters (we're still...

> @crisbusquets where should be the "Let visitors subscribe to new posts and comments via email" toggle in the new structure? AFAIK, this toggle works now as a "main toggle"...

Hi @pkuliga, I tested it with several themes and I've noticed a few things (non-urgent): - [ ] On some themes, the heading on the subscribe block has more weight...