cri-o icon indicating copy to clipboard operation
cri-o copied to clipboard

server: use max function instead of manually calculating max

Open haircommander opened this issue 1 month ago • 7 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

haircommander avatar May 15 '24 17:05 haircommander

/approve /lgtm

kwilczynski avatar May 15 '24 17:05 kwilczynski

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kwilczynski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 15 '24 17:05 openshift-ci[bot]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.58%. Comparing base (474a2ce) to head (0df9653). Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8184      +/-   ##
==========================================
- Coverage   49.58%   49.58%   -0.01%     
==========================================
  Files         153      153              
  Lines       16930    16950      +20     
==========================================
+ Hits         8395     8404       +9     
- Misses       7488     7499      +11     
  Partials     1047     1047              

codecov[bot] avatar May 15 '24 19:05 codecov[bot]

/retest

kwilczynski avatar May 15 '24 22:05 kwilczynski

/retest

sohankunkerkar avatar May 16 '24 15:05 sohankunkerkar

/retest

sohankunkerkar avatar May 16 '24 19:05 sohankunkerkar

/retest

kwilczynski avatar May 20 '24 12:05 kwilczynski

/test ci-cgroupv2-integration

kwilczynski avatar May 20 '24 14:05 kwilczynski