cri-o icon indicating copy to clipboard operation
cri-o copied to clipboard

[release-1.28] Revert "Fix ImageRef field for containers to default to an image ID"

Open saschagrunert opened this issue 2 years ago • 4 comments

What type of PR is this?

/kind bug

What this PR does / why we need it:

This reverts commit 41b13e28dd75828ab9cc24806ad4d2d3b4a605b9 and therefore https://github.com/cri-o/cri-o/pull/7149.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Reverted image ID field change in the container status.

saschagrunert avatar Feb 09 '24 08:02 saschagrunert

/approve /lgtm

kwilczynski avatar Feb 09 '24 09:02 kwilczynski

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Feb 09 '24 09:02 openshift-ci[bot]

/hold

for main.

saschagrunert avatar Feb 09 '24 09:02 saschagrunert

Codecov Report

Merging #7763 (8dc2041) into release-1.28 (3d08d8a) will decrease coverage by 0.25%. Report is 6 commits behind head on release-1.28. The diff coverage is 33.33%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #7763      +/-   ##
================================================
- Coverage         48.55%   48.31%   -0.25%     
================================================
  Files               136      136              
  Lines             15899    16687     +788     
================================================
+ Hits               7720     8062     +342     
- Misses             7268     7645     +377     
- Partials            911      980      +69     

codecov[bot] avatar Feb 09 '24 11:02 codecov[bot]

/unhold

saschagrunert avatar Feb 19 '24 15:02 saschagrunert