Christian Geddes issues

Repositories
Issues
Comments

Results 2 issues of


                                            Christian Geddes

msg param in mctp_message_tx should be const ptr and ptr to const

https://github.com/openbmc/libmctp/blob/ba6727e6d61d19720d4ca8756f465375adc82536/core.c#L610-L611 I appears that the value stored at the pointer and the value of the pointer itself are never altered so they should be labeled as const.

When writing KCS status register the bmc should write Status reg before writing to ODR

I think we are leaving ourselves open to a race condition if we set the ODR first. Setting the ODR will trigger the OBF bit in the status register which...