cargo-crev icon indicating copy to clipboard operation
cargo-crev copied to clipboard

Accidental changes during review

Open stefankreutz opened this issue 2 years ago • 6 comments

I'm a bit afraid to do reviews using cargo crev crate goto because I might accidentally change files under ~/.cargo/registry/src and thus corrupt local builds. Wouldn't it be better to create and go to a temporary directory instead?

stefankreutz avatar Jun 22 '22 09:06 stefankreutz

Maybe a good idea.

I wouldn't worry too much about it for now though, and IIRC cargo crev verify will warn about any "unceal" packages and cargo crev clean [<package>] will wipe them for you.

dpc avatar Jun 22 '22 17:06 dpc

There's cargo crev open that makes a temp copy.

kornelski avatar Aug 17 '22 21:08 kornelski

I thought open and goto were supposed to be the same, except one just for CLI, the other for IDE.

dpc avatar Aug 17 '22 21:08 dpc

They don't seem to be the same. goto goes to ~/.cargo/registry/src/github.com-1ecc6299db9ec823.

kornelski avatar Aug 18 '22 01:08 kornelski

Would it make sense to unify both of them so they both do a temp copy?

dpc avatar Aug 18 '22 01:08 dpc

Yeah

kornelski avatar Aug 18 '22 01:08 kornelski