Chad Retz
Chad Retz
> explanation We use `sealed` as recommended by https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1813. We did not disable this analyzer check. As mentioned there, we use things like `GetCustomAttribute` and performance is improved when it...
👍 I am not sure we want to support subclassing our attributes and so I think CA1813 is reasonable to leave enabled (which breaks compile unless we disable it). For...
:+1: I have changed the title to reflect that `ActivityDefinition.CreateWithoutAttribute` helper would help. We can have this accept attribute options without the attribute itself, similar to how `Create` works without...
I can understand it makes sense to internally bound the timer, but we should make the API responses accurate though if possible
To clarify, issue #380 inadvertently didn't set `global_tags` on Rust side. We need to make sure it is set and add a test or alter `test_different_runtimes` to confirm this setting...
The issue here is that we use OTel's Prometheus exporting which takes the approach at https://prometheus.io/docs/guides/opentelemetry/#including-resource-attributes-at-query-time. Namely the `global_tags` are on `target_info` which you can combine with the rest at...
Note, just for linking, this is caused by an upstream OTel Rust issue (our Rust core relies on this): https://github.com/open-telemetry/opentelemetry-rust/issues/2858
@gregbrowndev - with `global_tags` now applying to all metrics (something we didn't intend to undo), is that acceptable? Or are you asking for a new setting for, say, `target_info_tags`?
> For me, if we only had one option, it would make more sense to be able to configure the OTEL resource attributes / Prometheus target_info via the TelemetryConfig, rather...
Happy to do so! Will try to do so next week or the following.