creesch

Results 228 comments of creesch

Just commenting here to remind myself that the scope of this issue basically has grown to clean up a whole lot more. See the references for some of it :D

Came across this today and some things came to mind: - I can't remember if it was just for posts or also for comments, need to verify that. - Should...

Seems like a good suggestion, I adjusted the title as I think it might also be useful to have the same link in the modmail sidebar. You can only see...

Yeah... this is going to need some testing considering the huge version bump

I just had a look and for me a bunch of modules are missing now ![image](https://user-images.githubusercontent.com/2502190/197335871-558abc19-e296-40a3-8c39-652e13cb5a2a.png) > This does cause some flashing of the module list when opening the settings...

I guess related to #486 but we still might want to also make it an option.

I have to agree with @Geo1088 here in regards to mixing different naming conventions. So I'd rather see something along the lines of `--tb-global-header-background-color` or if we want to differentiate...

> That will need more thought, and I think in an ideal world we would split the cache by logged-in user and allow multiple cookie stores with the same logged-in...

https://github.com/toolbox-team/reddit-moderator-toolbox/blob/master/extension/data/background/handlers/cache.js#L9 This is what we have now. Looking at the code in this PR we might be able to leverage the cookieID as a prefix to store cache. Assuming the...

Removing this bit of logic should probably also be part of this PR https://github.com/toolbox-team/reddit-moderator-toolbox/blob/master/extension/data/init.js#L145-L149 At least, I assume it also works with incognito windows.