MarkdownPlus icon indicating copy to clipboard operation
MarkdownPlus copied to clipboard
verified publisher icon creecros

Update MarkdownPlusHelper.php

Open colonelpopcorn opened this issue 1 year ago • 2 comments

This allows us to override functionality at our pace. This should be relatively safe since Kanboard is in maintenance mode.

colonelpopcorn avatar May 20 '24 16:05 colonelpopcorn

@creecros Could I get a review on this PR, any concerns with extending the original helper?

colonelpopcorn avatar May 21 '24 14:05 colonelpopcorn

When i get a moment I will.

creecros avatar May 21 '24 14:05 creecros

I did some first tests with new MarkdownPlusHelper.php, heals the comments problem, until now no bad interactions seen.

My Configuration (KANBOARD installation for testing)

  • Application version: 1.2.36

  • PHP version: 8.3.6

  • PHP SAPI: fpm-fcgi

  • HTTP Client: cURL

  • OS version: Linux 5.4.0-181-generic

  • Database driver: mysql

  • Database version: 10.5.23-MariaDB-1:10.5.23+maria~ubu2004-log

  • Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:117.0a) Gecko/20100101 SeaMonkey/2.53.18, Build 20240329110002

  • Profile Language: English

  • Plugins:

    • Wiki 0.3.3a by Alfred
    • MarkdownPlus with modfied MarkdownPlusHelper.php (by colonelpopcorn 2024-05-20)

I will do more tests with full Plugins set, soon.

RainerBielefeld avatar May 31 '24 05:05 RainerBielefeld