thrift-typescript icon indicating copy to clipboard operation
thrift-typescript copied to clipboard

Import error for "thrift" in generated Typescript with thrift 0.13.0, 0.12.0 is OK.

Open mfickett opened this issue 5 years ago • 0 comments

To reproduce this issue:

  • Check out https://github.com/angelomelonas/thrift-spring-boot-vue-chat/tree/7f9423ff04e666096209f9aa86680bf5b37c483e
  • npm install and npm run serve => compiles and launches OK
  • Get the latest thrift-typescript: edit package.json to have "@creditkarma/thrift-typescript": "^3.7.6" (everything still works)

Then:

  • Upgrade the thrift dependency: edit package.json to have "thrift": "0.13.0"
  • npm install and npm run serve

Expected: Still works Observed:

This dependency was not found:

* thrift in ./codegen/Message.ts, ./codegen/ChatService.ts and 5 others

To install it, you can run: npm install --save thrift

mfickett avatar Aug 18 '20 19:08 mfickett