thrift-server icon indicating copy to clipboard operation
thrift-server copied to clipboard

thrift-client-ttwitter-filter: ttwitter classes not in package

Open jlai opened this issue 5 years ago • 3 comments

Trying to use the ttwitter filter gives this error:

Error: Cannot find module '../ttwitter/com/creditkarma/finagle/thrift'

Probably because the files list in package.json only has dist/main and not dist/ttwitter

jlai avatar Jul 25 '19 07:07 jlai

Hi @jlai, Can I get how ttwitter filter is being used in your use case.

ramakrishna-battala-ck avatar Oct 01 '19 03:10 ramakrishna-battala-ck

Using it as documented in the readme, e.g.

import {ThriftClientTTwitterFilter} from '@creditkarma/thrift-client-ttwitter-filter';

and connection.register(ThriftClientTTwitterFilter(filterOptions))

It's a packaging issue. Fixing it should be as simple as adding dist/ttwitter to https://github.com/creditkarma/thrift-server/blob/master/packages/thrift-client-ttwitter-filter/package.json

jlai avatar Oct 08 '19 22:10 jlai