fix: Unnecessary nested structure in API response under "data" field

[sayali-chavan2396]

Description: Some API responses introduce an unnecessary nested structure under the "data" field, which includes an additional "response" object.This makes the API responses unnecessarily complex and inconsistent with other endpoints.

Method

1. GET/v1/orgs/{orgId}/cred-defs/{credDefId} (Get credential definition by credential definition Id)
2. POST/v1/orgs/{orgId}/question-answer/question/{connectionId} (send question)
3. POST/v1/orgs/{orgId}/basic-message/{connectionId}(Send basic message)

Steps to Reproduce

1. Send an API request for above mention APIs .
2. Observe the response.

Current behavior

1.GET/v1/orgs/{orgId}/cred-defs/{credDefId} (Get credential definition by credential definition Id)

{ "statusCode": 200, "message": "Credential definition fetched successfully.", "data": { "response": {} } }

2. POST/v1/orgs/{orgId}/question-answer/question/{connectionId} (send question) { "statusCode": 201, "message": "Question sent successfully", "data": { "response": {} } }

3. POST/v1/orgs/{orgId}/basic-message/{connectionId}(Send basic message)

{ "statusCode": 201, "message": "Basic message sent successfully", "data": { "response": {} } }

Expected behavior

1.GET/v1/orgs/{orgId}/cred-defs/{credDefId} (Get credential definition by credential definition Id)

{ "statusCode": 200, "message": "Credential definition fetched successfully.", "data": { } }

2. POST/v1/orgs/{orgId}/question-answer/question/{connectionId} (send question)

{ "statusCode": 201, "message": "Question sent successfully", "data": {} }

3. POST/v1/orgs/{orgId}/basic-message/{connectionId}(Send basic message)

{ "statusCode": 201, "message": "Basic message sent successfully", "data": { } }

Screenshots

[sayali-chavan2396]

@GHkrishna I have reported an issue. Please review it when you have a chance. Let me know if you need any further information from my side. Thanks!

[kirti763]

Hey, I'd like to work on this.

[GHkrishna]

Hello @kirti763 Sure you can start working on this, assigning you this issue

[Muhammad-Aman1718]

@GHkrishna
I'd like to work on this.

[cmdsreedev]

I’d like to work on this issue. Could you please assign it to me? I’ll make sure to follow the contribution guidelines and submit a PR once it’s ready

[shubhambhoite502]

Hi @GHkrishna I would like to work on this issue. Could you please assign it to me?

[GHkrishna]

@shubhambhoite502 You can start working on it, and add a update here whenever you start

[abraaorochapb]

Hello @GHkrishna since it's been 3 weeks with no report about status, could you please assign the issue to me?

[GHkrishna]

Hi @abraaorochapb assigned you, feel free to raise a PR

[GHkrishna]

An observation, I believe the issue comes from the nats call where using a specific function from the few avaibale, add an additional mapper to nest the data field.

I had added a TODO earlier here: https://github.com/credebl/platform/blob/5f5b54d65c1513341eab504a95ac073b381ba485/libs/common/src/NATSClient.ts#L33