platform icon indicating copy to clipboard operation
platform copied to clipboard

fix: Incorrect error message when space is provided in 'connectionId' parameter

Open sayali-chavan2396 opened this issue 6 months ago • 10 comments

Description: When a space is passed as the value for the connectionId parameter in the API request, the response returns an incorrect error message. The current message states "Invalid format for connectionId"

Method

POST/v1/orgs/{orgId}/basic-message/{connectionId} (Send basic message)

Steps to Reproduce

  1. Send an API request with a space in the connectionId param.
  2. Observe the response.

Current behavior

{ "statusCode": 400, "message": "Invalid format for connectionId", "error": "Bad Request" }

Expected behavior

{ "statusCode": 400, "message": "Please provide valid connectionId", "error": "Bad Request" }

Screenshot

Image

sayali-chavan2396 avatar May 08 '25 11:05 sayali-chavan2396

Hey, I would like to work on this issue.

pallavi704 avatar May 10 '25 05:05 pallavi704

Thank you for your interest @pallavi704 Assigned you

GHkrishna avatar May 12 '25 05:05 GHkrishna

Hey @GHkrishna , thank you for assigning the issue. I will start working on this issue. Thanks.

pallavi704 avatar May 14 '25 17:05 pallavi704

is this issue solved..?

Saivenkat135 avatar Jun 12 '25 13:06 Saivenkat135

Hi @GHkrishna 👋

I noticed there hasn’t been any visible PR activity for this issue, so I’ve gone ahead and implemented a fix locally.

If it's okay with you, I’d love to submit a PR for it. Please let me know. Thanks! — Aryan

CodeWithAryanK avatar Jun 23 '25 17:06 CodeWithAryanK

Hello @CodeWithAryanK Sure, thank you for your interest and contribution, linking the PR for reference: https://github.com/credebl/platform/pull/1294

GHkrishna avatar Jun 24 '25 05:06 GHkrishna

Hi @GHkrishna 👋

Thanks for the quick response!

Just to clarify — PR #1294 was for the AgentType enum refactor.

This new message bug (#1229) is a separate issue. I’ve implemented a fix locally for this one as well — should I go ahead and raise a new PR?

Thanks again!

CodeWithAryanK avatar Jun 24 '25 07:06 CodeWithAryanK

Sure, that would be great.

Also, do you mind creating a PR against 'develop' branch as they are more likely to be merged sooner?

GHkrishna avatar Jun 24 '25 07:06 GHkrishna

Hi @GHkrishna 👋

Just wanted to let you know that I’ve raised the PR for issue #1229 as discussed.

Here’s the link to the PR: #1296 – fix: Improve error message for invalid connection Id

Let me know if any changes are needed. Thanks again! 🙌

CodeWithAryanK avatar Jun 24 '25 08:06 CodeWithAryanK

  • I’m really interested in working on this issue and would love to contribute to the project. Could you please assign this issue to me?

DeepDN avatar Sep 10 '25 12:09 DeepDN